Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1088763004: Update {virtual,override} to follow C++11 style in pdf. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in pdf. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/07903e579abf9f18d79935e1f531c7cd88503c58 Cr-Commit-Position: refs/heads/master@{#326456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M pdf/instance.h View 3 chunks +29 lines, -29 lines 0 comments Download
M pdf/out_of_process_instance.h View 2 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-23 03:22:22 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-23 04:51:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088763004/1
5 years, 8 months ago (2015-04-23 04:53:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 04:56:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 04:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07903e579abf9f18d79935e1f531c7cd88503c58
Cr-Commit-Position: refs/heads/master@{#326456}

Powered by Google App Engine
This is Rietveld 408576698