Plugin Power Saver: Add comprehensive browser tests.

chrome/browser/plugins/plugin_power_saver_browsertest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/strings/stringprintf.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/test/browser_test_utils.h"
+#include "content/public/test/ppapi_test_utils.h"
+#include "content/public/test/test_utils.h"
+#include "ppapi/shared_impl/ppapi_switches.h"
+#include "third_party/WebKit/public/web/WebInputEvent.h"
+#include "ui/gfx/geometry/point.h"
+
+class PluginPowerSaverBrowserTest : virtual public InProcessBrowserTest {
+ public:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kEnablePluginPowerSaver);
+    command_line->AppendSwitch(switches::kEnablePepperTesting);
+
+    ASSERT_TRUE(ppapi::RegisterPowerSaverTestPlugin(command_line));
+  }
+
+ protected:
+  void LoadHTML(const char* html) {
+    std::string url_str = "data:text/html;charset=utf-8,";
+    url_str.append(html);
+    ui_test_utils::NavigateToURL(browser(), GURL(url_str));
+    EXPECT_TRUE(content::WaitForRenderFrameReady(
+        GetActiveWebContents()->GetMainFrame()));
+  }
+
+  content::WebContents* GetActiveWebContents() {
+    return browser()->tab_strip_model()->GetActiveWebContents();
+  }
+
+  bool IsPluginPeripheral(const char* element_id) {
+    std::string script = base::StringPrintf(
+        "var plugin = window.document.getElementById('%s');"
+        "function handleEvent() {"
+        "  if (event.data.isPeripheral != undefined) {"
+        "    window.domAutomationController.send(event.data.isPeripheral);"
+        "    plugin.removeEventListener('message', handleEvent);"
+        "  }"
+        "}"
+        "if (plugin.postMessage == undefined) {"
+        "  window.domAutomationController.send(true);"
+        "} else {"
+        "  plugin.addEventListener('message', handleEvent);"
+        "  plugin.postMessage('isPeripheral');"
+        "}",
+        element_id);
+
+    bool result = false;
+    EXPECT_TRUE(content::ExecuteScriptAndExtractBool(GetActiveWebContents(),
+                                                     script, &result));
+    return result;
+  }
+
+  // This sends a simulated click at |point| and waits (by polling) for the
+  // plugin to be marked essential and run. Simply cycling the message loops
+  // does not work, as the renderer process must mark the plugin essential.
+  void SimulateClickAndAwaitMarkedEssential(const char* element_id,
+                                            const gfx::Point& point) {
+    content::SimulateMouseClickAt(GetActiveWebContents(), 0 /* modifiers */,
+                                  blink::WebMouseEvent::ButtonLeft, point);
+
+    std::string script = base::StringPrintf(
+        "function checkEssential() {"
+        "  var plugin = window.document.getElementById('%s');"
+        "  if (plugin.postMessage == undefined) {"
+        "    /* Placeholder still up. Try again in 50ms. */"
+        "    setTimeout(checkEssential, 50);"

[Paweł Hajdan Jr., 2015/04/20 22:38:17]

Is there no way to wait for a proper event instead of looping?

[tommycli, 2015/04/20 23:25:30]

Unfortunately, no. The replacement of the placeholder with the actual plugin
happens asynchronously in renderer process in response to the click.

Hypothetically we could hook into some kind of interprocess notification
mechanism, but just doing this seemed simpler.

[Paweł Hajdan Jr., 2015/04/21 15:54:49]

That sounds like "there is currently no easy way to do that", but I'd like to
understand it better.

Waiting for an even is strongly preferred, and it'll make all tests that need it
more solid (and likely easier to understand - you can easily identify which
places in the code trigger the even you're waiting for).

Could you explain more what would it take to implement some event? Maybe it
could be done all renderer-side, just trigger an event JS can wait for. I'm in
MTV this week, we can VC if that would help.

[tommycli, 2015/04/22 18:17:45]

Done.

+        "  } else {"
+        "    function handleEvent() {"
+        "      if (event.data.isPeripheral != undefined) {"
+        "        if (event.data.isPeripheral) {"
+        "          plugin.postMessage('isPeripheral');"
+        "        } else {"
+        "          window.domAutomationController.send(true);"
+        "          plugin.removeEventListener('message', handleEvent);"
+        "        }"
+        "      }"
+        "    }"
+        "    plugin.addEventListener('message', handleEvent);"
+        "    plugin.postMessage('isPeripheral');"
+        "  }"
+        "}"
+        "checkEssential();",
+        element_id);
+
+    bool result = false;
+    EXPECT_TRUE(content::ExecuteScriptAndExtractBool(GetActiveWebContents(),
+                                                     script, &result));
+    EXPECT_TRUE(result);
+  }
+};
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, SmallSameOrigin) {
+  LoadHTML(
+      "<object id='plugin' data='fake.swf' "
+      "type='application/x-ppapi-tests' width='400' height='100'></object>");
+  EXPECT_FALSE(IsPluginPeripheral("plugin"));
+}
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, SmallCrossOrigin) {
+  LoadHTML(
+      "<object id='plugin' data='http://otherorigin.com/fake.swf' "
+      "type='application/x-ppapi-tests' width='400' height='100'></object>");
+  EXPECT_TRUE(IsPluginPeripheral("plugin"));
+
+  SimulateClickAndAwaitMarkedEssential("plugin", gfx::Point(50, 50));
+}
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, LargeCrossOrigin) {
+  LoadHTML(
+      "<object id='plugin' data='http://otherorigin.com/fake.swf' "
+      "type='application/x-ppapi-tests' width='400' height='500'></object>");
+  EXPECT_FALSE(IsPluginPeripheral("plugin"));
+}
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, LargePluginsUsePosters) {
+  LoadHTML(
+      "<object id='plugin' type='application/x-ppapi-tests' "
+      "    width='400' height='500'>"
+      "  <param name='poster' value='snapshot1x.png 1x, snapshot2x.png 2x' />"
+      "</object>");
+  EXPECT_TRUE(IsPluginPeripheral("plugin"));
+}
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, OriginWhitelisting) {
+  LoadHTML(
+      "<object id='plugin1' data='http://otherorigin.com/fake1.swf' "
+      "type='application/x-ppapi-tests' width='400' height='100'></object>"
+      "<object id='plugin2' data='http://otherorigin.com/fake2.swf' "
+      "type='application/x-ppapi-tests' width='400' height='500'></object>");
+  EXPECT_FALSE(IsPluginPeripheral("plugin1"));
+  EXPECT_FALSE(IsPluginPeripheral("plugin2"));
+}
+
+IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, LargeCrossOriginObscured) {
+  LoadHTML(
+      "<div style='width: 100px; height: 100px; overflow: hidden;'>"
+      "  <object id='plugin' data='http://otherorigin.com/fake.swf' "
+      "  type='application/x-ppapi-tests' width='400' height='500'></object>"
+      "</div>");
+  EXPECT_TRUE(IsPluginPeripheral("plugin"));
+}