Kill CFX_Object.

Kill CFX_Object.

CFX_Object is a type that implements its own new operators that return
NULL on error. There's no need for this given the |new (std::nothrow)|
syntax; in fact, the current code can only work if there is no activity
in the constructors.  This may explain the pervasive lack of
constructors and reliance on Init() methods throughout the codebase.

The activity takes place in fx_memory.h, where FX_NEW is mapped onto
the std::nothrow syntax.  The rest is just cleanup.

Down the road, we will simply throw and remove all the error-checking
paths for new objects. Landing this patch first will at least show a
simple path back to the old behaviour without having to re-introduce
CFX_Object should someone want to do so in their own fork.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/4926900ab54a493d236291b5a24dfa4476792182

[Tom Sepez, 2015-04-13 23:46:35]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-04-13 23:46:47]

Lei, for review.

[Tom Sepez, 2015-04-13 23:48:22]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Tom Sepez, 2015-04-13 23:48:42]

+Bruce for windows-isms

[Lei Zhang, 2015-04-14 00:15:33]

On 2015/04/13 23:48:42, Tom Sepez wrote:
> +Bruce for windows-isms

BTW, it looks like fx_memory.h is the only interesting file in this CL.

[Lei Zhang, 2015-04-14 00:28:59]

lgtm

[brucedawson, 2015-04-14 18:59:33]

I haven't looked at it in detail but it seems good. An official looks-good could
be a while, so feel free to proceed without.

[Tom Sepez, 2015-04-14 19:54:43]

Committed patchset #2 (id:20001) manually as
4926900ab54a493d236291b5a24dfa4476792182 (presubmit successful).