tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py - Issue 1088693002: [Telemetry] Change BeginGestureInteraction to CreateGestureInteracion in telemetry/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

Issue 1088693002: [Telemetry] Change BeginGestureInteraction to CreateGestureInteracion in telemetry/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/unittest_util/page_test_test_case.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py b/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

index a305f396b063e579b53d8b03a8b094bc59ef75b7..e3702e62fbd17a4e5146831ad61c0eef9dd0d88e 100644

--- a/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py

@@ -102,14 +102,12 @@ class ScrollingPage(page_module.Page):

super(ScrollingPage, self).__init__(url, page_set, base_dir)

def RunPageInteractions(self, action_runner):

- interaction = action_runner.BeginGestureInteraction(

- 'ScrollAction')

- # Add 0.5s gap between when Gesture records are issued to when we actually

- # scroll the page.

- time.sleep(0.5)

- action_runner.ScrollPage()

- time.sleep(0.5)

- interaction.End()

+ with action_runner.CreateGestureInteraction('ScrollAction'):

+ # Add 0.5s gap between when Gesture records are issued to when we actually

+ # scroll the page.

+ time.sleep(0.5)

+ action_runner.ScrollPage()

+ time.sleep(0.5)

class SmoothGestureTest(page_test_test_case.PageTestTestCase):