Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1088683004: add textblob cache freeall (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTextBlobCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTextBlobCache.cpp View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
joshualitt
A simple patch to add freeAll() to the textblobcache.
5 years, 8 months ago (2015-04-16 17:45:37 UTC) #2
bsalomon
lgtm
5 years, 8 months ago (2015-04-16 18:05:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088683004/1
5 years, 8 months ago (2015-04-16 18:05:44 UTC) #5
bsalomon
https://codereview.chromium.org/1088683004/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/1088683004/diff/1/src/gpu/GrContext.cpp#newcode216 src/gpu/GrContext.cpp:216: fTextBlobCache->freeAll(); actually not sure we need this here. This ...
5 years, 8 months ago (2015-04-16 18:06:12 UTC) #6
joshualitt
https://codereview.chromium.org/1088683004/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/1088683004/diff/1/src/gpu/GrContext.cpp#newcode216 src/gpu/GrContext.cpp:216: fTextBlobCache->freeAll(); On 2015/04/16 18:06:11, bsalomon wrote: > actually not ...
5 years, 8 months ago (2015-04-16 18:08:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088683004/20001
5 years, 8 months ago (2015-04-16 18:09:22 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:24:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/26ffc00bfa09fe85c22ddcbeb0fc54c0eacb7859

Powered by Google App Engine
This is Rietveld 408576698