Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: gin/isolate_holder.cc

Issue 1088683003: Adding v8_isolate_memory_dump_provider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding heap_spaces child. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/gin.gyp ('k') | gin/public/isolate_holder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/isolate_holder.cc
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
index 2d7dcf7999c7a4fcaae062f3e32a7a50889af564..656ce09f51a14330fe46aaabb63b6a7b0b86a7ff 100644
--- a/gin/isolate_holder.cc
+++ b/gin/isolate_holder.cc
@@ -15,6 +15,7 @@
#include "gin/per_isolate_data.h"
#include "gin/run_microtasks_observer.h"
#include "gin/v8_initializer.h"
+#include "gin/v8_isolate_memory_dump_provider.h"
namespace gin {
@@ -37,6 +38,7 @@ IsolateHolder::IsolateHolder(AccessMode access_mode)
params.array_buffer_allocator = allocator;
isolate_ = v8::Isolate::New(params);
isolate_data_.reset(new PerIsolateData(isolate_, allocator));
+ isolate_memory_dump_provider_.reset(new V8IsolateMemoryDumpProvider(this));
#if defined(OS_WIN)
{
void* code_range;
@@ -64,6 +66,7 @@ IsolateHolder::~IsolateHolder() {
callback(code_range);
}
#endif
+ isolate_memory_dump_provider_.reset();
isolate_data_.reset();
isolate_->Dispose();
isolate_ = NULL;
« no previous file with comments | « gin/gin.gyp ('k') | gin/public/isolate_holder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698