Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2535)

Unified Diff: content/test/test_blink_web_unit_test_support.cc

Issue 1088683003: Adding v8_isolate_memory_dump_provider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing message loop check. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_blink_web_unit_test_support.cc
diff --git a/content/test/test_blink_web_unit_test_support.cc b/content/test/test_blink_web_unit_test_support.cc
index 07f53ea70a7ed2f66459fba7fd648072612a2d71..c0ad2b9df3a6b20df61d7c22d5c826d34cb8e6f8 100644
--- a/content/test/test_blink_web_unit_test_support.cc
+++ b/content/test/test_blink_web_unit_test_support.cc
@@ -7,6 +7,7 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
+#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/strings/utf_string_conversions.h"
#include "components/scheduler/renderer/renderer_scheduler.h"
@@ -44,6 +45,7 @@
namespace content {
TestBlinkWebUnitTestSupport::TestBlinkWebUnitTestSupport() {
+ base::MessageLoop message_loop;
Primiano Tucci (use gerrit) 2015/04/29 17:45:11 Hmm this will destroy the messageloop after the ct
Sami 2015/04/29 17:48:23 Ah, sorry for not picking up on this. In my head w
#if defined(OS_MACOSX)
base::mac::ScopedNSAutoreleasePool autorelease_pool;
#endif
@@ -55,11 +57,9 @@ TestBlinkWebUnitTestSupport::TestBlinkWebUnitTestSupport() {
gin::V8Initializer::LoadV8Snapshot();
#endif
- if (base::MessageLoopProxy::current()) {
- renderer_scheduler_ = scheduler::RendererScheduler::Create();
- web_thread_.reset(new scheduler::WebThreadImplForRendererScheduler(
- renderer_scheduler_.get()));
- }
+ renderer_scheduler_ = scheduler::RendererScheduler::Create();
+ web_thread_.reset(new scheduler::WebThreadImplForRendererScheduler(
+ renderer_scheduler_.get()));
blink::initialize(this);
blink::setLayoutTestMode(true);
« no previous file with comments | « no previous file | gin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698