Adding v8_isolate_memory_dump_provider.

gin/isolate_holder.cc

Index: gin/isolate_holder.cc
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
index 9ef41d374a0625296ab82a5e02b995ffc9383274..50463401206dfed459f71cbe1b79a2ff0f857d43 100644
--- a/gin/isolate_holder.cc
+++ b/gin/isolate_holder.cc
@@ -15,6 +15,7 @@
 #include "gin/per_isolate_data.h"
 #include "gin/run_microtasks_observer.h"
 #include "gin/v8_initializer.h"
+#include "gin/v8_isolate_memory_dump_provider.h"
 
 namespace gin {
 
@@ -43,9 +44,11 @@ IsolateHolder::IsolateHolder() {
       callback(code_range, size);
   }
 #endif
+  isolate_memory_dump_provider_.reset(new V8IsolateMemoryDumpProvider(this));

[rmcilroy, 2015/04/21 17:13:03]

nit - move to below isolate_data_.reset

[ssid, 2015/04/21 17:38:23]

Done.

 }
 
 IsolateHolder::~IsolateHolder() {
+  isolate_memory_dump_provider_.reset();

[rmcilroy, 2015/04/21 17:13:03]

Do you need this reset? The scoped_ptr will delete the referenced object at the
end of the destructor anyway so this is only needed if you explicitly need to
delete it before the destructor code.

[ssid, 2015/04/21 17:17:48]

It was added here so that before the object gets unregistered, if the isolate
gets destroyed, then it will cause a crash.

   if (task_observer_.get())
     base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
 #if defined(OS_WIN)