fix sunflower -- dom types were not resolving

fix sunflower -- dom types were not resolving

R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/784959dd6e9bb9477eae86b2bb7d766549d1b047

[Jennifer Messerly, 2015-04-13 19:08:41]

jmesserly@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2015-04-13 19:27:14]

https://codereview.chromium.org/1088663002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1088663002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:343: NamedExpression named = args[0];
seems like we should add a helper method to extract named string parameters from
annotations.

https://codereview.chromium.org/1088663002/diff/1/test/codegen/expect/sunflow...
File test/codegen/expect/sunflower/dom.js (right):

https://codereview.chromium.org/1088663002/diff/1/test/codegen/expect/sunflow...
test/codegen/expect/sunflower/dom.js:41: exports.InputElement = InputElement;
all these lines except for ones that actually have a rename are wasteful

exports starts out as window which already has all these members on it.
options:
restrict exports to only contain the explicitly exposed classes (possibly better
for debugging but more fragile and slower) 
keep having 
dom = window
and only add exports that have an explicit Dart rename.

[Jennifer Messerly, 2015-04-13 20:02:10]

https://codereview.chromium.org/1088663002/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1088663002/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:343: NamedExpression named = args[0];
On 2015/04/13 19:27:14, Jacob wrote:
> seems like we should add a helper method to extract named string parameters
from
> annotations.

Sure thing. Ultimately we need these in analyzer though, or they aren't really
discoverable.

https://codereview.chromium.org/1088663002/diff/1/test/codegen/expect/sunflow...
File test/codegen/expect/sunflower/dom.js (right):

https://codereview.chromium.org/1088663002/diff/1/test/codegen/expect/sunflow...
test/codegen/expect/sunflower/dom.js:41: exports.InputElement = InputElement;
On 2015/04/13 19:27:14, Jacob wrote:
> all these lines except for ones that actually have a rename are wasteful
> 
> exports starts out as window which already has all these members on it.
> options:
> restrict exports to only contain the explicitly exposed classes (possibly
better
> for debugging but more fragile and slower) 
> keep having 
> dom = window
> and only add exports that have an explicit Dart rename.

hmmm. That's a good point, I forgot that we make "window" the module global for
"dom". That's probably not going to work in ES6 ... maybe we could re-export all
names:

    export { * } from 'window';

or have smarts when we generate imports:

    import { Document } from 'window';
    import { InputElement } from 'dart/dom';

or even smarter:

    import { Document, InputElement as HTMLInputElement } from 'window';

[Jennifer Messerly, 2015-04-13 20:02:16]

PTAL

[Jacob, 2015-04-13 20:11:36]

lgtm

[Jennifer Messerly, 2015-04-13 20:22:27]

Committed patchset #2 (id:20001) manually as
784959dd6e9bb9477eae86b2bb7d766549d1b047 (presubmit successful).