Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1088633002: Unprefix flexbox tests. (Closed)

Created:
5 years, 8 months ago by cbiesinger
Modified:
5 years, 8 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Unprefix flexbox tests. This is the result of some perl scripts: perl -pi -e 's/-webkit-flex/flex/g' * perl -pi -e 's/-webkit-inline-flex/inline-flex/g' * perl -pi -e 's/-webkit-justify/justify/g' * perl -pi -e 's/-webkit-align/align/g' * (for scripting:) perl -pi -e 's/webkitFlex/flex/g' * perl -pi -e 's/webkitAlign/align/g' * perl -pi -e 's/webkitJustify/justify/g' * I have then reverted the change to display-flexbox-set-get.html, which intentionally sets the prefixed values (to ensure that both ways work). I then manually went through and removed all -moz-flex, and removed now-duplicate lines in cross-axis-scrollbar.html, and trailing whitespace in several more tests. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193664

Patch Set 1 #

Total comments: 1

Patch Set 2 : also fix platform-specific expectation #

Patch Set 3 : -moz- prefixes and minor changes #

Patch Set 4 : whoops, a > went missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1562 lines, -1583 lines) Patch
M LayoutTests/css3/flexbox/align-absolute-child.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/anonymous-block-merge-crash.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/auto-height-dynamic.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/auto-margins.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/box-sizing.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/columns-auto-size.html View 1 2 3 chunks +18 lines, -18 lines 0 comments Download
M LayoutTests/css3/flexbox/columns-height-set-via-top-bottom.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/content-height-with-scrollbars.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/cross-axis-scrollbar.html View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/css-properties.html View 4 chunks +171 lines, -171 lines 0 comments Download
M LayoutTests/css3/flexbox/css-properties-expected.txt View 2 chunks +188 lines, -188 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-algorithm.html View 1 2 5 chunks +29 lines, -33 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-algorithm-min-max.html View 1 2 3 3 chunks +15 lines, -19 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-algorithm-with-margins.html View 1 2 3 chunks +14 lines, -19 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-align.html View 1 chunk +141 lines, -141 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-align-baseline.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/flex-align-column.html View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-align-max.html View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow.html View 3 chunks +36 lines, -36 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-auto-margins.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-border.html View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-initial.html View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-initial-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-margins.html View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-margins-auto-size.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-margins-auto-size-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-orientations.html View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-overflow.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-flow-padding.html View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-item-child-overflow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-justify-content.html View 2 chunks +31 lines, -31 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-longhand-parsing.html View 1 chunk +40 lines, -40 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-longhand-parsing-expected.txt View 1 chunk +31 lines, -31 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-no-flex.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-order.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-order-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-property-parsing.html View 1 chunk +191 lines, -191 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-property-parsing-expected.txt View 1 chunk +109 lines, -109 lines 0 comments Download
M LayoutTests/css3/flexbox/flexbox-baseline.html View 6 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/css3/flexbox/flexbox-overflow-auto.html View 3 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/css3/flexbox/flexbox-overflow-auto-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/flexitem.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/flexitem-stretch-image.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/flexitem-stretch-range.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/floated-flexbox.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/floated-flexitem.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/inline-flex.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/inline-flex-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/inline-flex-crash2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/insert-text-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/intrinsic-min-width-applies-with-fixed-width.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/line-wrapping.html View 17 chunks +21 lines, -21 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline.html View 3 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-align-content.html View 15 chunks +36 lines, -36 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-align-content-horizontal-column.html View 3 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-align-self.html View 3 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-column-auto.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-justify-content.html View 2 chunks +14 lines, -14 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-min-max.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-reverse-wrap-baseline.html View 2 chunks +14 lines, -14 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-reverse-wrap-overflow.html View 2 chunks +30 lines, -30 lines 0 comments Download
M LayoutTests/css3/flexbox/multiline-shrink-to-fit.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/css3/flexbox/negative-flex-rounding-assert.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/nested-orthogonal-flexbox-relayout.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/nested-orthogonal-flexbox-relayout-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/nested-stretch.html View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/css3/flexbox/order-painting.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/orthogonal-flex-directions.html View 1 2 4 chunks +33 lines, -33 lines 0 comments Download
M LayoutTests/css3/flexbox/overflow-keep-scrollpos.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/percent-margins.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/percentage-heights.html View 4 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/css3/flexbox/percentage-sizes.html View 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/css3/flexbox/percentage-sizes-quirks.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/css3/flexbox/perpendicular-writing-modes-inside-flex-item.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/position-absolute-child.html View 5 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/css3/flexbox/position-absolute-children.html View 3 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/css3/flexbox/preferred-widths.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/css3/flexbox/preferred-widths-orthogonal.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/relayout-align-items.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-column-reverse.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/repaint-rtl-column.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/css3/flexbox/stretch-input-in-column-expected.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/css3/flexbox/stretched-child-shrink-on-relayout.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/flexbox/style-change.html View 3 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/css3/flexbox/true-centering.html View 3 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/css3/flexbox/writing-modes.html View 2 chunks +65 lines, -65 lines 0 comments Download
M LayoutTests/css3/flexbox/z-index.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/css3/flexbox/line-wrapping-expected.txt View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
cbiesinger
5 years, 8 months ago (2015-04-13 18:43:19 UTC) #1
leviw_travelin_and_unemployed
https://codereview.chromium.org/1088633002/diff/1/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html File LayoutTests/css3/flexbox/anonymous-block-merge-crash.html (right): https://codereview.chromium.org/1088633002/diff/1/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html#newcode1 LayoutTests/css3/flexbox/anonymous-block-merge-crash.html:1: <div style="display:flex; display:-moz-flex;"><div id="inner"></div>If this page doesn't crash then ...
5 years, 8 months ago (2015-04-13 19:55:41 UTC) #2
cbiesinger
On 2015/04/13 19:55:41, leviw wrote: > https://codereview.chromium.org/1088633002/diff/1/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html > File LayoutTests/css3/flexbox/anonymous-block-merge-crash.html (right): > > https://codereview.chromium.org/1088633002/diff/1/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html#newcode1 > ...
5 years, 8 months ago (2015-04-13 19:56:33 UTC) #3
leviw_travelin_and_unemployed
On 2015/04/13 at 19:56:33, cbiesinger wrote: > On 2015/04/13 19:55:41, leviw wrote: > > https://codereview.chromium.org/1088633002/diff/1/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html ...
5 years, 8 months ago (2015-04-13 19:57:00 UTC) #4
cbiesinger
On 2015/04/13 19:57:00, leviw wrote: > On 2015/04/13 at 19:56:33, cbiesinger wrote: > > On ...
5 years, 8 months ago (2015-04-13 20:15:24 UTC) #5
leviw_travelin_and_unemployed
Whew! That's a mouthful! LGTM and thanks for doing the less mechanical part!
5 years, 8 months ago (2015-04-13 20:19:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088633002/40001
5 years, 8 months ago (2015-04-13 20:20:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088633002/60001
5 years, 8 months ago (2015-04-13 21:57:57 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 01:43:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193664

Powered by Google App Engine
This is Rietveld 408576698