Pepper: Add a X-Requested-With header to URL requests done for Pepper plugins.

Pepper: Add a X-Requested-With header to URL requests done for Pepper plugins.

The header contains the name and version of the plugin. (It'll be done for NPAPI
separately.)

BUG=145090

[jschuh, 2012-08-29 21:14:03]

On 2012/08/29 21:04:13, viettrungluu wrote:

lgtm, but it really should have a test (though that would be ugly to implement
right now).

[brettw, 2012-08-30 05:30:49]

Can you discuss with somebody familiar with the test server to see if this can
be reasonably tested? It seems like a delicate thing we'll never notice is
broken.

[viettrungluu, 2012-08-30 17:40:02]

On 2012/08/30 05:30:49, brettw wrote:
> Can you discuss with somebody familiar with the test server to see if this can
> be reasonably tested? It seems like a delicate thing we'll never notice is
> broken.

It's possible to test (the test server supports echoing headers), but putting
the test in the ppapi/test directory seems a bit wrong (since it's not testing
PPAPI per se).

(It's not terribly hard either, just mildly annoying since we don't set a name
for the test plugin, so it gets the name of the .dll/.so/.plugin.)

[brettw, 2012-08-30 17:54:11]

It seems like we should just set the name then.

[viettrungluu, 2012-08-30 22:20:28]

On 2012/08/30 17:54:11, brettw wrote:
> It seems like we should just set the name then.

Done, and test added. PTAL.

[brettw, 2012-08-30 23:04:32]

LGTM, thanks for figuring out the test stuff.

[commit-bot: I haz the power, 2012-08-31 17:30:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10886047/9001

[commit-bot: I haz the power, 2012-08-31 19:22:35]

Try job failure for 10886047-9001 (retry) on mac_rel for steps
"nacl_integration, browser_tests".
It's a second try, previously, steps "nacl_integration, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[viettrungluu, 2012-08-31 22:56:22]

Crap, this breaks CORS from Pepper. I'm going to have to rework a bunch of
things.... Sigh.

On 2012/08/31 19:22:35, I haz the power (commit-bot) wrote:
> Try job failure for 10886047-9001 (retry) on mac_rel for steps
> "nacl_integration, browser_tests".
> It's a second try, previously, steps "nacl_integration, browser_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[viettrungluu, 2012-12-17 20:53:17]

jschuh, brettw: PTAL (after 3+ months). (I also enforced a user-agent-like
format for the value of the header.)

+darin: Since I had to add more stuff to
WebURLRequestExtraDataImpl/RequestExtraData, which still makes me sad (but I
still don't have a substantially better idea). Hrm.

[viettrungluu, 2012-12-17 20:57:51]

(Look at Patch Set 4, that is.)

[jschuh, 2012-12-17 21:12:48]

lgtm

[brettw, 2012-12-17 23:02:55]

lgtm

[darin (slow to review), 2012-12-18 00:50:03]

Trung and I spoke in person about this.  I don't feel comfortable adding
this header for NaCl requests.  It seems like NaCl should be able to do
anything JS can do, but applying this header to NaCl based requests might
cause NaCl to be blocked by a site.

Now, that said, there may be room for doing something like this when NaCl
is used by a Chrome Extension to register a MIME handler.  In that case,
the NaCl module would be loaded on pages that did not request it, and which
are on a different origin.

-Darin


On Mon, Dec 17, 2012 at 3:02 PM, <brettw@chromium.org> wrote:

> lgtm
>
>
>
>
https://codereview.chromium.**org/10886047/<https://codereview.chromium.org/1...
>

[Tom Sepez, 2014-07-22 19:49:29]

Sooo ... If we were to revive this approach, but only for the Flash plugin,
would that make folks more comfortable?

[darin (slow to review), 2014-07-22 20:35:44]

On 2014/07/22 19:49:29, Tom Sepez wrote:
> Sooo ... If we were to revive this approach, but only for the Flash plugin,
> would that make folks more comfortable?

I'm OK doing whatever with Flash.