Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1088593006: Update {virtual,override} to follow C++11 style in ash. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in ash. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7 Cr-Commit-Position: refs/heads/master@{#326391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -41 lines) Patch
M ash/host/ash_remote_window_tree_host_win.h View 1 chunk +11 lines, -11 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M ash/system/win/audio/tray_audio_delegate_win.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ash/test/test_metro_viewer_process_host.h View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-22 21:03:24 UTC) #2
James Cook
lgtm
5 years, 8 months ago (2015-04-22 21:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088593006/1
5 years, 8 months ago (2015-04-22 21:16:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 23:15:17 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:16:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b0cc2654f792b8865ca9615f247a881c23826b7
Cr-Commit-Position: refs/heads/master@{#326391}

Powered by Google App Engine
This is Rietveld 408576698