Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 1088593005: drive: Do not rely on argument-dependent lookup when calling MD5DigestToBase16(). (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

drive: Do not rely on argument-dependent lookup when calling MD5DigestToBase16(). Looks like C++ compiler is able to figure out that this function is on base namespace by deducing this from the dependent type base::MD5Digest. For more reference on ADL: http://en.wikipedia.org/wiki/Argument-dependent_name_lookup http://stackoverflow.com/questions/8111677/what-is-argument-dependent-lookup-aka-adl-or-koenig-lookup I found this while doing https://codereview.chromium.org/1099453002/. The error is like the following: ../../chrome/browser/drive/drive_api_util.cc:171:10: error: use of undeclared identifier 'MD5DigestToBase16'; did you mean 'base::MD5DigestToBase16'? return MD5DigestToBase16(digest); ^~~~~~~~~~~~~~~~~ base::MD5DigestToBase16 Log: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/81070/steps/compile/logs/stdio BUG=None R=hashimoto@chromium.org Committed: https://crrev.com/4bbb4bdb858d96d43e32d6d7da2d921f759e2893 Cr-Commit-Position: refs/heads/master@{#326949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/drive/drive_api_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
5 years, 8 months ago (2015-04-22 20:45:14 UTC) #1
hashimoto
lgtm
5 years, 8 months ago (2015-04-23 04:26:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088593005/1
5 years, 8 months ago (2015-04-24 23:46:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-25 02:10:24 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 02:11:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bbb4bdb858d96d43e32d6d7da2d921f759e2893
Cr-Commit-Position: refs/heads/master@{#326949}

Powered by Google App Engine
This is Rietveld 408576698