Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1088583005: Fix metadata loss when revalidating search provider logo. (Closed)

Created:
5 years, 8 months ago by newt (away)
Modified:
5 years, 8 months ago
Reviewers:
Ted C, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix metadata loss when revalidating search provider logo. Previously, when revaliding a cached search provider's logo, the mime_type of the image and the URL of the animated image to show (if any) were dropped. This fixes those bugs and adds tests. BUG=480090 Committed: https://crrev.com/3a171a20534963af96e28129c1019882afe83c97 Cr-Commit-Position: refs/heads/master@{#326664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M components/search_provider_logos/google_logo_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/search_provider_logos/logo_tracker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 5 chunks +50 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
newt (away)
PTAL. It's similar to your CL, but treats animated_url differently, and beefs up the tests ...
5 years, 8 months ago (2015-04-23 03:46:47 UTC) #2
justincohen
LGTM, Thanks! This should be merged to branch.
5 years, 8 months ago (2015-04-23 13:03:38 UTC) #3
newt (away)
+tedchoc for committers approval
5 years, 8 months ago (2015-04-23 18:03:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088583005/1
5 years, 8 months ago (2015-04-23 18:03:53 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-23 18:03:57 UTC) #10
Ted C
On 2015/04/23 18:03:57, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 8 months ago (2015-04-23 20:47:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088583005/1
5 years, 8 months ago (2015-04-23 21:14:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:02:28 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:03:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a171a20534963af96e28129c1019882afe83c97
Cr-Commit-Position: refs/heads/master@{#326664}

Powered by Google App Engine
This is Rietveld 408576698