Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1088563003: Update vertexAttribIPointer in GPU command buffer (Closed)

Created:
5 years, 8 months ago by legend
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update vertexAttribIPointer in GPU command buffer BUG=429053 Committed: https://crrev.com/87543be305f7512c14f717fdc1c293a0bc5504cc Cr-Commit-Position: refs/heads/master@{#327226}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove personal email #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -6 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +16 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +17 lines, -3 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +70 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
legend
PTAL if have time. Thanks!
5 years, 8 months ago (2015-04-27 06:55:08 UTC) #3
Zhenyao Mo
LGTM
5 years, 8 months ago (2015-04-27 20:16:56 UTC) #4
piman
not lgtm because of AUTHORS file, but happy to accept once that is fixed. https://codereview.chromium.org/1088563003/diff/20001/AUTHORS ...
5 years, 8 months ago (2015-04-27 23:39:27 UTC) #5
Zhenyao Mo
On 2015/04/27 23:39:27, piman (Very slow to review) wrote: > not lgtm because of AUTHORS ...
5 years, 8 months ago (2015-04-27 23:45:34 UTC) #6
legend
Thanks for the review. Sorry about adding personal email because I saw that some of ...
5 years, 7 months ago (2015-04-28 00:59:55 UTC) #7
piman
LGTM, thanks!
5 years, 7 months ago (2015-04-28 01:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088563003/40001
5 years, 7 months ago (2015-04-28 01:07:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-04-28 03:01:11 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 03:02:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87543be305f7512c14f717fdc1c293a0bc5504cc
Cr-Commit-Position: refs/heads/master@{#327226}

Powered by Google App Engine
This is Rietveld 408576698