Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: shell/in_process_native_runner.cc

Issue 1088533003: Adding URLResponse Disk Cache to mojo. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/in_process_native_runner.h ('k') | shell/native_application_support.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/in_process_native_runner.cc
diff --git a/shell/in_process_native_runner.cc b/shell/in_process_native_runner.cc
index f12708dda99e7ce32b3bfefebca6fa5e405023a4..f5ae3ee140262512837ddd415721a603447886bf 100644
--- a/shell/in_process_native_runner.cc
+++ b/shell/in_process_native_runner.cc
@@ -14,7 +14,7 @@
namespace shell {
InProcessNativeRunner::InProcessNativeRunner(Context* context)
- : cleanup_(NativeApplicationCleanup::DONT_DELETE), app_library_(nullptr) {
+ : app_library_(nullptr) {
}
InProcessNativeRunner::~InProcessNativeRunner() {
@@ -30,11 +30,9 @@ InProcessNativeRunner::~InProcessNativeRunner() {
void InProcessNativeRunner::Start(
const base::FilePath& app_path,
- NativeApplicationCleanup cleanup,
mojo::InterfaceRequest<mojo::Application> application_request,
const base::Closure& app_completed_callback) {
app_path_ = app_path;
- cleanup_ = cleanup;
DCHECK(!application_request_.is_pending());
application_request_ = application_request.Pass();
@@ -56,7 +54,7 @@ void InProcessNativeRunner::Run() {
<< " thread id=" << base::PlatformThread::CurrentId();
// TODO(vtl): ScopedNativeLibrary doesn't have a .get() method!
- base::NativeLibrary app_library = LoadNativeApplication(app_path_, cleanup_);
+ base::NativeLibrary app_library = LoadNativeApplication(app_path_);
app_library_.Reset(app_library);
RunNativeApplication(app_library, application_request_.Pass());
app_completed_callback_runner_.Run();
« no previous file with comments | « shell/in_process_native_runner.h ('k') | shell/native_application_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698