Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: shell/application_manager/native_runner.h

Issue 1088533003: Adding URLResponse Disk Cache to mojo. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/application_manager/local_fetcher.cc ('k') | shell/application_manager/network_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/native_runner.h
diff --git a/shell/application_manager/native_runner.h b/shell/application_manager/native_runner.h
index e18f214101647c7d5e1cb3fe429de7a233573c62..e50bb084729b536ed9ac4b9a2bbd8a3f13c3d8ee 100644
--- a/shell/application_manager/native_runner.h
+++ b/shell/application_manager/native_runner.h
@@ -24,16 +24,15 @@ class NativeRunner {
virtual ~NativeRunner() {}
// Loads the app in the file at |app_path| and runs it on some other
- // thread/process. If |cleanup| is |DELETE|, this takes ownership of the file.
+ // thread/process.
// |app_completed_callback| is posted (to the thread on which |Start()| was
// called) after |MojoMain()| completes, or on any error (including if it
// fails to start).
- // TODO(vtl): |app_path| and |cleanup| should probably be moved to the
- // factory's Create(). Rationale: The factory may need information from the
- // file to decide what kind of NativeRunner to make.
+ // TODO(vtl): |app_path| should probably be moved to the factory's Create().
+ // Rationale: The factory may need information from the file to decide what
+ // kind of NativeRunner to make.
virtual void Start(
const base::FilePath& app_path,
- NativeApplicationCleanup cleanup,
mojo::InterfaceRequest<mojo::Application> application_request,
const base::Closure& app_completed_callback) = 0;
};
« no previous file with comments | « shell/application_manager/local_fetcher.cc ('k') | shell/application_manager/network_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698