Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1088533002: Convert BitmapTextBatch from STArray to AutoSTMalloc (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@attryst
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert BitmapTextBatch from STArray to AutoSTMalloc BUG=skia: Committed: https://skia.googlesource.com/skia/+/ad802c66c96e40016d4ba13b6dac3e6c6f17a774

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Total comments: 4

Patch Set 4 : comments updated #

Patch Set 5 : rebase #

Patch Set 6 : windows warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -24 lines) Patch
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 5 7 chunks +56 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-13 14:21:54 UTC) #2
bsalomon
lgtm w/ comment and rename requests. And we should delete the STArray rather than comment ...
5 years, 8 months ago (2015-04-13 15:06:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088533002/100001
5 years, 8 months ago (2015-04-15 12:24:18 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:31:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/ad802c66c96e40016d4ba13b6dac3e6c6f17a774

Powered by Google App Engine
This is Rietveld 408576698