Fixed ExtractSearchTermsFromURL for search engines with encoding != "UTF-8".

Fixed ExtractSearchTermsFromURL for search engines with encoding != "UTF-8".

Some search engines specify non UTF-8 input encoding, e.g. the "mail.ru" engine specifies "windows-1251". After this patch the TemplateURL::ExtractSearchTermsFromURL function works correctly in such cases.

R=pkasting@chromium.org

Committed: https://crrev.com/27804d10158be631d7519099cdd01480339db175
Cr-Commit-Position: refs/heads/master@{#325220}

[Peter Kasting, 2015-04-13 18:59:48]

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
File components/search_engines/template_url_unittest.cc (right):

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
components/search_engines/template_url_unittest.cc:1145: TEST_F(TemplateURLTest,
ExtractSearchTermsFromURL_CyrillicInWindows1251) {
Nit: I would name this "ExtraceSearchTermsFromNonUTF8URL" and the next one
"ExtraceSearchTermsFromUTF8URL".

Add comments on these describing what they're trying to test.

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
components/search_engines/template_url_unittest.cc:1158:
EXPECT_EQ(base::UTF8ToUTF16("Здравствуй, мир!"), result);
Don't put extended characters directly into source code -- use C++ escaped
values.

That unfortunately makes this less readable, but it's safer and less likely to
break on systems with different default encodings.

[Vitaly Baranov, 2015-04-14 13:26:15]

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
File components/search_engines/template_url_unittest.cc (right):

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
components/search_engines/template_url_unittest.cc:1145: TEST_F(TemplateURLTest,
ExtractSearchTermsFromURL_CyrillicInWindows1251) {
On 2015/04/13 18:59:48, Peter Kasting wrote:
> Nit: I would name this "ExtraceSearchTermsFromNonUTF8URL" and the next one
> "ExtraceSearchTermsFromUTF8URL".
> 
> Add comments on these describing what they're trying to test.

Done.

https://codereview.chromium.org/1088523002/diff/1/components/search_engines/t...
components/search_engines/template_url_unittest.cc:1158:
EXPECT_EQ(base::UTF8ToUTF16("Здравствуй, мир!"), result);
On 2015/04/13 18:59:48, Peter Kasting wrote:
> Don't put extended characters directly into source code -- use C++ escaped
> values.
> 
> That unfortunately makes this less readable, but it's safer and less likely to
> break on systems with different default encodings.

Done.

[Peter Kasting, 2015-04-14 20:52:25]

LGTM

[Vitaly Baranov, 2015-04-15 07:47:07]

The CQ bit was checked by vitbar@yandex-team.ru

[commit-bot: I haz the power, 2015-04-15 07:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1088523002/20001

[commit-bot: I haz the power, 2015-04-15 10:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 10:55:42]

Patchset 2 (id:??) landed as
https://crrev.com/27804d10158be631d7519099cdd01480339db175
Cr-Commit-Position: refs/heads/master@{#325220}