Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1088513006: content_child: Explicitly depend on blink_image_resources. (Closed)

Created:
5 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
5 years, 8 months ago
Reviewers:
Elliot Glaysher, jam, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, mrunal
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content_child: Explicitly depend on blink_image_resources. Commit a3c614c9 ("Part 4 of ??: Move blink images to their own grd/pak files") introduced a dependency on the newly-generated blink_resources.h header in blink_platform_impl.cc, but did not explicitly made the content_child target depend on the target that generated it. Other targets elsewhere work fine because they depend on one or more pak files also generated by the grit invocation, but that is not the case for content_child, which only uses the header that's created. BUG=467176, 471609 TEST=ninja -C out/Release content_child [from scratch] R=erg@chromium.org, jam@chromium.org, sky@chromium.org Committed: https://crrev.com/9f07769a87f59dd4f70b9a481a4f594faf18c8ab Cr-Commit-Position: refs/heads/master@{#325651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_child.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Raphael Kubo da Costa (rakuco)
5 years, 8 months ago (2015-04-17 11:13:46 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-17 15:31:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088513006/1
5 years, 8 months ago (2015-04-17 15:33:46 UTC) #4
jam
lgtm
5 years, 8 months ago (2015-04-17 15:33:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 16:35:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 16:41:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f07769a87f59dd4f70b9a481a4f594faf18c8ab
Cr-Commit-Position: refs/heads/master@{#325651}

Powered by Google App Engine
This is Rietveld 408576698