Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1088513002: Revert of Disable flaky ShellApiTest.Basic. (Closed)

Created:
5 years, 8 months ago by rmcilroy
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-to-frame
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky ShellApiTest.Basic. (patchset #1 id:1 of https://codereview.chromium.org/1029893007/) Reason for revert: The underlying issue should now be fixed. Original issue's description: > Disable flaky ShellApiTest.Basic. > > BUG=470873 > TBR=yoz@chromium.org > NOTRY=true > > Committed: https://crrev.com/12433c0cdc2cc004e662203a9519c7d8ba500afe > Cr-Commit-Position: refs/heads/master@{#322385} TBR=yoz@chromium.org,dgozman@chromium.org,jamescook@chromium.org BUG=470133, 470873 Committed: https://crrev.com/26ae1e24488ef107941898fc0e0bf88bd2dc9331 Cr-Commit-Position: refs/heads/master@{#324843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M extensions/shell/browser/shell_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmcilroy
Created Revert of Disable flaky ShellApiTest.Basic.
5 years, 8 months ago (2015-04-13 12:57:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088513002/1
5 years, 8 months ago (2015-04-13 12:59:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 13:34:58 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 13:35:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26ae1e24488ef107941898fc0e0bf88bd2dc9331
Cr-Commit-Position: refs/heads/master@{#324843}

Powered by Google App Engine
This is Rietveld 408576698