Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1088503003: Avoid modifying the real context chain for debug evaluation. (Closed)

Created:
5 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 8 months ago
Reviewers:
Yang, yurys
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid modifying the real context chain for debug evaluation. Instead of modifying a context chain and then modifying it back, causing potential mismatches, we clone the inner context chain and evaluate the expression in this cloned context. We then copy all local variable values back if needed. R=yangguo@chromium.org,yurys@chromium.org Committed: https://crrev.com/219f4a9eb42b14563ce4c4930770dd74d0dde5f8 Cr-Commit-Position: refs/heads/master@{#27809}

Patch Set 1 #

Patch Set 2 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -16 lines) Patch
M src/runtime/runtime-debug.cc View 3 chunks +34 lines, -16 lines 0 comments Download
A test/mjsunit/debug-evaluate-locals-capturing.js View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Dmitry Lomov (no reviews)
ptal
5 years, 8 months ago (2015-04-13 14:06:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088503003/20001
5 years, 8 months ago (2015-04-13 14:09:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1944)
5 years, 8 months ago (2015-04-13 14:12:36 UTC) #5
Dmitry Lomov (no reviews)
ping
5 years, 8 months ago (2015-04-14 07:52:00 UTC) #6
Yang
lgtm
5 years, 8 months ago (2015-04-14 09:06:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088503003/20001
5 years, 8 months ago (2015-04-14 09:06:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-14 09:08:07 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 09:08:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/219f4a9eb42b14563ce4c4930770dd74d0dde5f8
Cr-Commit-Position: refs/heads/master@{#27809}

Powered by Google App Engine
This is Rietveld 408576698