Assignment expressions in tree IR.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 377 matching lines @@
   @override
   js.Expression visitVariableUse(tree_ir.VariableUse node) {
     return buildVariableAccess(node.variable);
   }
 
   js.Expression buildVariableAccess(tree_ir.Variable variable) {
     return new js.VariableUse(getVariableName(variable));
   }
 
   @override
+  js.Expression visitAssign(tree_ir.Assign node) {
+    return new js.Assignment(
+        buildVariableAccess(node.variable),
+        visitExpression(node.value));
+  }
+
+  @override
   void visitContinue(tree_ir.Continue node) {
     tree_ir.Statement fallthrough = this.fallthrough;
     if (node.target.binding == fallthrough) {
       // Fall through to continue target
     } else if (fallthrough is tree_ir.Continue &&
                fallthrough.target == node.target) {
       // Fall through to equivalent continue
     } else {
       usedLabels.add(node.target);
       accumulator.add(new js.Continue(node.target.name));
@@ skipping 29 matching lines @@
     fallthrough = fallthroughStatement;
     js.Statement result = buildBody();
     if (usedLabels.remove(label)) {
       result = new js.LabeledStatement(label.name, result);
     }
     fallthrough = savedFallthrough;
     return result;
   }
 
   @override
-  void visitAssign(tree_ir.Assign node) {
-    tree_ir.Expression value = node.value;
-    js.Expression definition = visitExpression(value);
-
-    accumulator.add(new js.ExpressionStatement(new js.Assignment(
-        buildVariableAccess(node.variable),
-        definition)));
-    visitStatement(node.next);
-  }
-
-  @override
   void visitBreak(tree_ir.Break node) {
     tree_ir.Statement fallthrough = this.fallthrough;
     if (node.target.binding.next == fallthrough) {
       // Fall through to break target
     } else if (fallthrough is tree_ir.Break &&
                fallthrough.target == node.target) {
       // Fall through to equivalent break
     } else {
       usedLabels.add(node.target);
       accumulator.add(new js.Break(node.target.name));
@@ skipping 85 matching lines @@
   }
 
   @override
   js.Expression visitGetField(tree_ir.GetField node) {
     return new js.PropertyAccess.field(
         visitExpression(node.object),
         glue.instanceFieldPropertyName(node.field));
   }
 
   @override
-  void visitSetField(tree_ir.SetField node) {
+  js.Assignment visitSetField(tree_ir.SetField node) {
     js.PropertyAccess field =
         new js.PropertyAccess.field(
             visitExpression(node.object),
             glue.instanceFieldPropertyName(node.field));
-    js.Assignment asn = new js.Assignment(field, visitExpression(node.value));
-    accumulator.add(new js.ExpressionStatement(asn));
-    visitStatement(node.next);
+    return new js.Assignment(field, visitExpression(node.value));
   }
 
   js.Expression buildStaticHelperInvocation(FunctionElement helper,
                                             List<js.Expression> arguments) {
     registry.registerStaticUse(helper);
     return buildStaticInvoke(new Selector.fromElement(helper), helper,
         arguments);
   }
 
   @override
@@ skipping 38 matching lines @@
   @override
   visitFunctionExpression(tree_ir.FunctionExpression node) {
     return errorUnsupportedNode(node);
   }
 
   @override
   visitFunctionDeclaration(tree_ir.FunctionDeclaration node) {
     return errorUnsupportedNode(node);
   }
 
+  @override
+  visitVariableDeclaration(tree_ir.VariableDeclaration node) {
+    return errorUnsupportedNode(node);
+  }
+
   errorUnsupportedNode(tree_ir.DartSpecificNode node) {
     throw "Unsupported node in JS backend: $node";
   }
 }