Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: Source/core/dom/AXObjectCache.cpp

Issue 1088473002: Refactor ScopedAXObjectCache to remove ref count (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/AXObjectCache.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 22 matching lines...) Expand all
33 namespace blink { 33 namespace blink {
34 34
35 AXObjectCache::AXObjectCacheCreateFunction AXObjectCache::m_createFunction = nul lptr; 35 AXObjectCache::AXObjectCacheCreateFunction AXObjectCache::m_createFunction = nul lptr;
36 36
37 void AXObjectCache::init(AXObjectCacheCreateFunction function) 37 void AXObjectCache::init(AXObjectCacheCreateFunction function)
38 { 38 {
39 ASSERT(!m_createFunction); 39 ASSERT(!m_createFunction);
40 m_createFunction = function; 40 m_createFunction = function;
41 } 41 }
42 42
43 AXObjectCache* AXObjectCache::create(Document& document) 43 PassOwnPtr<AXObjectCache> AXObjectCache::create(Document& document)
44 { 44 {
45 ASSERT(m_createFunction); 45 ASSERT(m_createFunction);
46 return (m_createFunction)(document); 46 return (m_createFunction)(document);
47 } 47 }
48 48
49 AXObjectCache::AXObjectCache() 49 AXObjectCache::AXObjectCache()
50 { 50 {
51 } 51 }
52 52
53 AXObjectCache::~AXObjectCache() 53 AXObjectCache::~AXObjectCache()
54 { 54 {
55 } 55 }
56 56
57 PassOwnPtr<ScopedAXObjectCache> ScopedAXObjectCache::create(Document& document)
58 {
59 return adoptPtr(new ScopedAXObjectCache(document));
60 }
61
57 ScopedAXObjectCache::ScopedAXObjectCache(Document& document) 62 ScopedAXObjectCache::ScopedAXObjectCache(Document& document)
58 : m_document(document) 63 : m_ownedCache(nullptr)
haraken 2015/05/28 08:50:08 This wouldn't be necessary.
keishi 2015/05/29 05:05:05 Done.
59 , m_cache(0) 64 , m_cache(nullptr)
60 { 65 {
61 if (AXObjectCache* existingCache = document.axObjectCache()) { 66 if (AXObjectCache* existingCache = document.axObjectCache()) {
62 m_cache = existingCache; 67 m_cache = existingCache;
63 m_isScoped = false;
64 } else { 68 } else {
65 m_isScoped = true; 69 m_ownedCache = AXObjectCache::create(document);
66 m_cache = AXObjectCache::create(m_document); 70 m_cache = m_ownedCache.get();
67 } 71 }
68 } 72 }
69 73
70 ScopedAXObjectCache::~ScopedAXObjectCache()
71 {
72 if (m_isScoped)
73 delete m_cache;
74 }
75
76 AXObjectCache* ScopedAXObjectCache::get() 74 AXObjectCache* ScopedAXObjectCache::get()
77 { 75 {
78 ASSERT(m_cache); 76 ASSERT(m_cache);
79 return m_cache; 77 return m_cache;
80 } 78 }
81 79
82 AXObjectCache* ScopedAXObjectCache::operator->()
83 {
84 return get();
85 }
86
87 } // namespace blink 80 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/AXObjectCache.h ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698