Issue 1088423003: [Password manager tests automation] Fix instagram website test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088423003: [Password manager tests automation] Fix instagram website test. (Closed)

Created:
5 years, 8 months ago by melandory

Modified:
5 years, 8 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_runner_test

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Password manager tests automation] Fix instagram website test. Looks like instagram has removed iframe. BUG=369521 R=vabr@chromium.org Committed: https://crrev.com/e021896e4fa4f539248e3f6c4f0a6ee6b8a1c99b Cr-Commit-Position: refs/heads/master@{#325419}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	components/test/data/password_manager/automated_tests/tests.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

vabr (Chromium)

Thanks for the fix. Also great, that the iframe was removed. :) LGTM Vaclav

5 years, 8 months ago (2015-04-16 11:01:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088423003/1

5 years, 8 months ago (2015-04-16 11:13:14 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 11:52:05 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e021896e4fa4f539248e3f6c4f0a6ee6b8a1c99b
Cr-Commit-Position: refs/heads/master@{#325419}