Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1088423002: X87: Array() in optimized code can create with wrong ElementsKind in corner cases (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Array() in optimized code can create with wrong ElementsKind in corner cases port 13459c1ae3caa4cc546c522177bac5450a3252bf (r27857) original commit message: Array() in optimized code can create with wrong ElementsKind in corner cases. Calling new Array(JSObject::kInitialMaxFastElementArray) in optimized code makes a stub call that bails out due to the length. Currently, the bailout code a) doesn't have the allocation site, and b) wouldn't use it if it did because the length is perceived to be too high. This CL passes the allocation site to the stub call (rather than undefined), and alters the bailout code to utilize the feedback. BUG= Committed: https://crrev.com/5729299752c2ea3d2cae1844219273afc9ada3ca Cr-Commit-Position: refs/heads/master@{#27875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 8 months ago (2015-04-16 07:02:30 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-16 09:38:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088423002/1
5 years, 8 months ago (2015-04-16 09:39:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 10:38:47 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 10:38:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5729299752c2ea3d2cae1844219273afc9ada3ca
Cr-Commit-Position: refs/heads/master@{#27875}

Powered by Google App Engine
This is Rietveld 408576698