Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1088383003: remove unused (by clients) SkPathUtils (Closed)

Created:
5 years, 8 months ago by reed2
Modified:
5 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused (by clients) SkPathUtils BUG=skia: Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -528 lines) Patch
D bench/PathUtilsBench.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/utils/SkPathUtils.h View 1 chunk +0 lines, -40 lines 0 comments Download
D samplecode/SamplePathUtils.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D src/utils/SkPathUtils.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D tests/PathUtilsTest.cpp View 1 chunk +0 lines, -152 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed2
are these used in android?
5 years, 8 months ago (2015-04-16 02:25:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088383003/1
5 years, 8 months ago (2015-04-16 02:25:35 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-16 02:31:36 UTC) #6
scroggo
lgtm Nope.
5 years, 8 months ago (2015-04-16 13:16:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088383003/1
5 years, 8 months ago (2015-04-16 13:16:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7
5 years, 8 months ago (2015-04-16 13:16:42 UTC) #10
jcgregorio
On 2015/04/16 at 13:16:42, commit-bot wrote: > Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7 This CL ...
5 years, 8 months ago (2015-04-16 16:13:27 UTC) #11
jcgregorio
5 years, 8 months ago (2015-04-16 16:47:14 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1060703003/ by jcgregorio@google.com.

The reason for reverting is: This change is causing the DEPS roll to fail:


http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu....

Powered by Google App Engine
This is Rietveld 408576698