Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1088353002: Prevent text eliding in ash TimeView. (Closed)

Created:
5 years, 8 months ago by Jun Mukai
Modified:
5 years, 8 months ago
Reviewers:
stevenjb, oshima
CC:
chromium-reviews, kalyank, sadrul, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent text eliding in ash TimeView. TimeView should have enough space to show the time, but even if it doesn't assign enough space, it shouldn't replace a part of the text by elipsis (...). BUG=471297 R=stevenjb@chromium.org, oshima@chromium.org Committed: https://crrev.com/a4ac116cd050502a86bc5058a4bca5b91d71c996 Cr-Commit-Position: refs/heads/master@{#325362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/system/date/date_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jun Mukai
5 years, 8 months ago (2015-04-15 21:39:40 UTC) #1
oshima
lgtm
5 years, 8 months ago (2015-04-15 23:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088353002/1
5 years, 8 months ago (2015-04-16 00:07:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 00:55:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 00:57:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4ac116cd050502a86bc5058a4bca5b91d71c996
Cr-Commit-Position: refs/heads/master@{#325362}

Powered by Google App Engine
This is Rietveld 408576698