Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1088313006: [Android] Update ContentCommandLineTest to only use lowercase switches. (Closed)

Created:
5 years, 8 months ago by jackhou1
Modified:
5 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Update ContentCommandLineTest to only use lowercase switches. This enables https://codereview.chromium.org/1046363002/ which enforces lowercase switches in base::CommandLine::HasSwitch. BUG=472383 Committed: https://crrev.com/624cb4aecbf47bfc0f586f86206dc98e5aaf3e0a Cr-Commit-Position: refs/heads/master@{#326196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentCommandLineTest.java View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
yfriedman, could you take a look?
5 years, 8 months ago (2015-04-21 02:31:09 UTC) #2
Yaron
lgtm
5 years, 8 months ago (2015-04-21 14:24:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088313006/1
5 years, 8 months ago (2015-04-22 00:25:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 00:47:41 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 00:48:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/624cb4aecbf47bfc0f586f86206dc98e5aaf3e0a
Cr-Commit-Position: refs/heads/master@{#326196}

Powered by Google App Engine
This is Rietveld 408576698