Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 1088283002: Adds Android Test Bot to git cl try. (Closed)

Created:
5 years, 8 months ago by rudominer
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing comma. #

Patch Set 3 : Add missing entry to map. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rudominer
This is what I got when I did git cl try: rudominer@caerus:~/mojo/src$ git cl try ...
5 years, 8 months ago (2015-04-15 18:22:21 UTC) #2
jamesr
Sorry you also have to add it to the map in GetDefaultTryConfigs that defines the ...
5 years, 8 months ago (2015-04-15 18:24:28 UTC) #3
rudominer
ptal
5 years, 8 months ago (2015-04-15 19:09:58 UTC) #4
jamesr
lgtm
5 years, 8 months ago (2015-04-15 19:30:42 UTC) #5
rudominer
5 years, 8 months ago (2015-04-15 19:36:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8239264b84de3cc9f28a7a36771628dbf48ce284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698