Ensure isolates have a root library so createMirrorSystem() and spawnUri() are happy.

Ensure isolates have a root library so createMirrorSystem() and spawnUri() are happy.

https://github.com/domokit/mojo/issues/98

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/239f84e08f35cf080b5992f79ba5875c87e03e36

[rmacnak, 2015-04-16 00:57:09]

rmacnak@google.com changed reviewers:
+ eseidel@google.com

[eseidel, 2015-04-16 01:51:36]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-04-16 01:51:36]

Does spawnURI try to make urls relative to the root library's URI?

We should also add a test for this.  I'm happy to help create such tomorrow.

[eseidel, 2015-04-16 21:50:30]

lgtm

[eseidel, 2015-04-16 21:51:18]

Yes, we should be able to test this, by adding a test to:
https://github.com/domokit/mojo/tree/master/sky/tests
and running sky/tools/test_sky to confirm.

But I have too many other things going on today to fret about it. :) lgtm.

[rmacnak, 2015-04-16 22:47:12]

On 2015/04/16 21:51:18, eseidel wrote:
> Yes, we should be able to test this, by adding a test to:
> https://github.com/domokit/mojo/tree/master/sky/tests
> and running sky/tools/test_sky to confirm.
> 
> But I have too many other things going on today to fret about it. :) lgtm.

Added one for createMirrorSystem.

[eseidel, 2015-04-16 22:47:52]

lgtm

[eseidel, 2015-04-16 22:48:29]

Please add https://github.com/domokit/mojo/issues/98 to your CL descriptoin
before landing and Github will auto update/clsoe the bug.

[eseidel, 2015-04-16 22:48:52]

nm, turns out I can edit your descriptions. :)

[rmacnak, 2015-04-16 22:49:21]

Committed patchset #2 (id:20001) manually as
239f84e08f35cf080b5992f79ba5875c87e03e36 (presubmit successful).

[rmacnak, 2015-04-16 22:51:13]

On 2015/04/16 22:48:52, eseidel wrote:
> nm, turns out I can edit your descriptions. :)

Just in time too :)