Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 108823002: chromium-status: improve status field editing (Closed)

Created:
7 years ago by vapier
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-status: improve status field editing Tweak slightly the input field to be a <textarea> rather than an <input type=text>. The statuses can often times be very long which makes editing in a narrow input textbox difficult. A textarea allows for slightly larger default display, but also browsers have UI elements so the user can expand things as needed themselves. BUG=chromium:314501 TEST=ran an appengine instance and checked the status behavior TEST=`./tests/main_test.py` passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259321

Patch Set 1 #

Patch Set 2 : fix up status __init__ #

Total comments: 2

Patch Set 3 : replace newlines with spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M static/js/main/main.js View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M status.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M templates/main.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
vapier
6 years, 9 months ago (2014-03-17 23:12:01 UTC) #1
agable
https://codereview.chromium.org/108823002/diff/20001/status.py File status.py (right): https://codereview.chromium.org/108823002/diff/20001/status.py#newcode144 status.py:144: kwargs['message'] = kwargs.get('message', '').replace('\n', '') newlines should be replaced ...
6 years, 9 months ago (2014-03-25 17:17:18 UTC) #2
vapier
https://codereview.chromium.org/108823002/diff/20001/status.py File status.py (right): https://codereview.chromium.org/108823002/diff/20001/status.py#newcode144 status.py:144: kwargs['message'] = kwargs.get('message', '').replace('\n', '') Done.
6 years, 9 months ago (2014-03-25 18:01:12 UTC) #3
szager1
lgtm
6 years, 9 months ago (2014-03-25 18:39:48 UTC) #4
vapier
The CQ bit was checked by vapier@chromium.org
6 years, 9 months ago (2014-03-25 20:21:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/108823002/60001
6 years, 9 months ago (2014-03-25 20:21:39 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 20:21:54 UTC) #7
Message was sent while issue was closed.
Change committed as 259321

Powered by Google App Engine
This is Rietveld 408576698