Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1088223003: Improve commit message generation for deploy_sdk. (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve commit message generation for deploy_sdk. Hopefully this will make it slightly more clear that the sky_sdk repository is not actually a stand-alone repository, but rather generated by a script. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1ed4f93d515d2d9121600859ea683b1ea6dbbb51

Patch Set 1 #

Patch Set 2 : Update per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M sky/tools/deploy_sdk.py View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 8 months ago (2015-04-15 21:03:55 UTC) #1
Hixie
lgtm with changes we dicussed
5 years, 8 months ago (2015-04-15 21:12:49 UTC) #2
eseidel
5 years, 8 months ago (2015-04-15 21:13:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ed4f93d515d2d9121600859ea683b1ea6dbbb51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698