Issue 1088183004: Revert of Fix scroll regression when specifying an extension id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088183004: Revert of Fix scroll regression when specifying an extension id. (Closed)

Created:
5 years, 8 months ago by Xi Han

Modified:
5 years, 8 months ago

Reviewers:
Devlin, Dan Beam, hcarmona, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, Devlin

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/) Reason for revert: It might cause the failures of: -ExtensionSettingsCommandsConfigWebUITest.testChromeSendHandler -ExtensionSettingsWebUITest.testChromeSendHandled http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/1149 Original issue's description: > Fix scroll regression when specifying an extension id. > > Issue was caused because scrolling the page should happen after the > extensions are visible. > > BUG=473002 > > Committed: https://crrev.com/4eaeca8aa713e9b7b1f214413bfdac87956fd51d > Cr-Commit-Position: refs/heads/master@{#325278} TBR=kalman@chromium.org,dbeam@chromium.org,rdevlin.cronin@chromium.org,hcarmona@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473002 Committed: https://crrev.com/488846cd562f444831982d82ef0bc9ca0dd79028 Cr-Commit-Position: refs/heads/master@{#325300}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -21 lines)			Patch
	M	chrome/browser/resources/extensions/extension_list.js	View		2 chunks	+8 lines, -21 lines	0 comments	Download
	M	chrome/browser/resources/extensions/extensions.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Xi Han

Created Revert of Fix scroll regression when specifying an extension id.

5 years, 8 months ago (2015-04-15 20:48:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088183004/1

5 years, 8 months ago (2015-04-15 20:51:07 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 20:54:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/488846cd562f444831982d82ef0bc9ca0dd79028
Cr-Commit-Position: refs/heads/master@{#325300}