Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1088183003: Remove GTalk Pepper interfaces and related code. (Closed)

Created:
5 years, 8 months ago by Josh Horwich
Modified:
5 years, 8 months ago
Reviewers:
bbudge, jam, jschuh
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GTalk Pepper interfaces and related code. Remove obsolete private Pepper interface private/ppb_talk_private.h, associated Pepper plumbing code, strings, and chrome::PepperTalkHost. These are no longer needed as support for Pepper GTalk has been dropped. BUG=392002 TEST=browser_tests Committed: https://crrev.com/c2c781c51f26ae067110d8c82aa7c26643649611 Cr-Commit-Position: refs/heads/master@{#325310}

Patch Set 1 #

Patch Set 2 : Missed a few references #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1335 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/renderer_host/pepper/pepper_talk_host.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/renderer_host/pepper/pepper_talk_host.cc View 1 chunk +0 lines, -257 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/ppapi_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/resource_creation_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/api/private/ppb_talk_private.idl View 1 chunk +0 lines, -142 lines 0 comments Download
D ppapi/c/private/ppb_talk_private.h View 1 chunk +0 lines, -159 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +0 lines, -67 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 3 chunks +0 lines, -4 lines 2 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 3 chunks +0 lines, -16 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D ppapi/proxy/talk_resource.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ppapi/proxy/talk_resource.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D ppapi/proxy/talk_resource_unittest.cc View 1 chunk +0 lines, -171 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/tests/test_talk_private.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/tests/test_talk_private.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M ppapi/thunk/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +0 lines, -4 lines 0 comments Download
D ppapi/thunk/ppb_talk_private_api.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/thunk/ppb_talk_private_thunk.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jam
content&chrome lgtm
5 years, 8 months ago (2015-04-15 19:42:31 UTC) #2
bbudge
Pepper LGTM https://codereview.chromium.org/1088183003/diff/20001/ppapi/ppapi_proxy.gypi File ppapi/ppapi_proxy.gypi (left): https://codereview.chromium.org/1088183003/diff/20001/ppapi/ppapi_proxy.gypi#oldcode292 ppapi/ppapi_proxy.gypi:292: 'proxy/ppb_talk_private_proxy.cc', I guess this file doesn't exist, ...
5 years, 8 months ago (2015-04-15 20:53:00 UTC) #3
Josh Horwich
jschuh@ ptal ppapi/proxy/ppapi_messages.h - FYI, I'm simply removing now-unused messages here. https://codereview.chromium.org/1088183003/diff/20001/ppapi/ppapi_proxy.gypi File ppapi/ppapi_proxy.gypi (left): ...
5 years, 8 months ago (2015-04-15 21:10:49 UTC) #4
jschuh
ipc security lgtm +∞
5 years, 8 months ago (2015-04-15 21:23:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088183003/20001
5 years, 8 months ago (2015-04-15 21:29:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 21:35:13 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:36:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2c781c51f26ae067110d8c82aa7c26643649611
Cr-Commit-Position: refs/heads/master@{#325310}

Powered by Google App Engine
This is Rietveld 408576698