chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 108813011: Add base:: namespace to string16 in chrome/browser/extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 108813011: Add base:: namespace to string16 in chrome/browser/extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_message_bubble_controller.cc ('k') | chrome/browser/extensions/suspicious_extension_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

index dfa18e5b28c1aa55e5428ece6fae134c6bd043ce..169b45aec2f5f98cebc1ab7514eb48459dcd45b4 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

@@ -260,7 +260,8 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_WipeoutControllerTest) {

EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id2_));

EXPECT_FALSE(controller->ShouldShow());

- std::vector<string16> suspicious_extensions = controller->GetExtensionList();

+ std::vector<base::string16> suspicious_extensions =

+ controller->GetExtensionList();

EXPECT_EQ(0U, suspicious_extensions.size());

EXPECT_EQ(0U, controller->link_click_count());

EXPECT_EQ(0U, controller->dismiss_click_count());

@@ -325,7 +326,8 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_DevModeControllerTest) {

// The list will contain one enabled unpacked extension.

EXPECT_TRUE(controller->ShouldShow());

- std::vector<string16> dev_mode_extensions = controller->GetExtensionList();

+ std::vector<base::string16> dev_mode_extensions =

+ controller->GetExtensionList();

ASSERT_EQ(2U, dev_mode_extensions.size());

EXPECT_TRUE(ASCIIToUTF16("Extension 2") == dev_mode_extensions[0]);

EXPECT_TRUE(ASCIIToUTF16("Extension 1") == dev_mode_extensions[1]);