Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1088093003: Return cropBitmap (Closed)

Created:
5 years, 8 months ago by Zoran Jovanovic
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Return cropBitmap cropBitmap returns 'true' on success and 'false' on failure. Propagate its return value so that cascading failures can be avoided. Signed-off-by: Mykola Kondratenko <mykola.kondratenko@sonymobile.com>; BUG=skia: Committed: https://skia.googlesource.com/skia/+/7f00acbda6d35d2ba445a1e2909bb599b156cc5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Zoran Jovanovic
5 years, 8 months ago (2015-04-15 10:47:36 UTC) #2
scroggo
On 2015/04/15 10:47:36, Zoran Jovanovic wrote: lgtm
5 years, 8 months ago (2015-04-15 11:54:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088093003/1
5 years, 8 months ago (2015-04-15 12:40:19 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:48:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7f00acbda6d35d2ba445a1e2909bb599b156cc5c

Powered by Google App Engine
This is Rietveld 408576698