Deflake LayoutTests/svg/animations/viewspec-animated-viewbox.html

Deflake LayoutTests/svg/animations/viewspec-animated-viewbox.html

BUG=479823
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194385

[payal.pandey, 2015-04-24 06:26:43]

payal.pandey@samsung.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[payal.pandey, 2015-04-24 06:26:43]

Resolved the flaky test case for svg viewbox CL : 235256
Please have a look.

[fs, 2015-04-24 09:21:26]

On 2015/04/24 06:26:43, payal.pandey wrote:
> Resolved the flaky test case for svg viewbox CL : 235256
> Please have a look.

Please expand a bit on why this fixes the flakiness.

[payal.pandey, 2015-04-24 09:52:19]

As viewspec-animated-viewbox-expected.html  and viewspec-animated-viewbox.html
outputs images were not matching.

So resolved for mismatches in both the testcase.

[fs, 2015-04-24 10:24:53]

On 2015/04/24 09:52:19, payal.pandey wrote:
> As viewspec-animated-viewbox-expected.html  and viewspec-animated-viewbox.html
> outputs images were not matching.
 
I think the interesting part is the "why", not the "what". FWIW, this looks ok
to me, but it'd be good to know why the old TC was flaky and the new isn't.

I think could change the subject to something like:

"Deflake LayoutTests/svg/animations/viewspec-animated-viewbox.html"

and hopefully add something to the description that says why.

[payal.pandey, 2015-04-24 10:30:05]

I copied the test case from existing viewspec-viewboxparams.html and due to
that, I dint actually checked it in run-webkit-tests.

So it was purely my mistake.

[fs, 2015-04-24 12:06:06]

lgtm if you've done a run-webkit-tests invocation locally like described by pdr
in a different review. (It won't hurt bumping 100 to 1000.)

[payal.pandey, 2015-04-24 12:08:54]

On 2015/04/24 12:06:06, fs wrote:
> lgtm if you've done a run-webkit-tests invocation locally like described by
pdr
> in a different review. (It won't hurt bumping 100 to 1000.)

Yes, excecuted command run-webkit-tests --iterations=100

[payal.pandey, 2015-04-24 12:09:02]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-24 12:09:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1088083003/1

[commit-bot: I haz the power, 2015-04-24 12:31:49]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194385