DO NOT SUBMIT: initial Chromecast patch for https://codereview.chromium.org/1053113002/

DO NOT SUBMIT: initial Chromecast patch for https://codereview.chromium.org/1053113002/

BUG=

[DaleCurtis, 2015-04-15 16:30:58]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2015-04-15 16:30:58]

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
File chromecast/renderer/media/chromecast_media_renderer_factory.cc (right):

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/chromecast_media_renderer_factory.cc:65: new
CmaRenderer(cma_media_pipeline.Pass(), video_renderer_sink));
This looks fine to me, but it's up to your team if somewhere in MediaPipeline is
a more natural fit; similar to how AudioRendererSink might be managed.

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/chromecast_media_renderer_factory.cc:69:
video_renderer_sink));
Note, you'll need to be careful about who starts and stops the VideoRendererSink
in the future since you're handing it out to both renderers.

[gunsch, 2015-04-15 16:38:09]

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
File chromecast/renderer/media/chromecast_media_renderer_factory.cc (right):

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/chromecast_media_renderer_factory.cc:65: new
CmaRenderer(cma_media_pipeline.Pass(), video_renderer_sink));
On 2015/04/15 16:30:58, DaleCurtis wrote:
> This looks fine to me, but it's up to your team if somewhere in MediaPipeline
is
> a more natural fit; similar to how AudioRendererSink might be managed.

MediaPipelineProxy mostly coordinates a few dumb pipes to the browser-side
pipeline; I think CmaRenderer will be most appropriate going forward.

https://codereview.chromium.org/1088063002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/chromecast_media_renderer_factory.cc:69:
video_renderer_sink));
On 2015/04/15 16:30:58, DaleCurtis wrote:
> Note, you'll need to be careful about who starts and stops the
VideoRendererSink
> in the future since you're handing it out to both renderers. 

Good thought. We only ever initialize one of the renderers, but we could
consider more lazily creating them at some point.