Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1088023003: Web content context menu shows over chrome://bookmarks menu. (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web content context menu shows over chrome://bookmarks menu. Earlier 'contextmenu' event is getting passed to the background page and due to this WebPage context menu is coming on top of menu button context menu. Changes done so that 'contextmenu' event will get handled and not passed to background page on similar lines as in context_menuu_handler.js file. BUG=442200 Committed: https://crrev.com/fad165dd29dada35d38edb569eb8cce2ad7b797c Cr-Commit-Position: refs/heads/master@{#326230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M ui/webui/resources/js/cr/ui/menu_button.js View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
Please review. Thanks
5 years, 8 months ago (2015-04-21 11:48:03 UTC) #2
Bernhard Bauer
lgtm
5 years, 8 months ago (2015-04-21 16:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088023003/1
5 years, 8 months ago (2015-04-22 02:42:36 UTC) #5
Deepak
On 2015/04/21 16:07:45, Bernhard Bauer wrote: > lgtm Thankyou.
5 years, 8 months ago (2015-04-22 02:42:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 05:04:38 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 05:05:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fad165dd29dada35d38edb569eb8cce2ad7b797c
Cr-Commit-Position: refs/heads/master@{#326230}

Powered by Google App Engine
This is Rietveld 408576698