Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: content/common/BUILD.gn

Issue 1088013002: gn: Fix gn build so cloud_print_unittests doesn't fail. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do jam@'s suggestion. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/BUILD.gn
diff --git a/content/common/BUILD.gn b/content/common/BUILD.gn
index b73a71b6ebb994d09adaa0999bc2db665ceed936..d093840095c81763b1adf006aec21a6104351f52 100644
--- a/content/common/BUILD.gn
+++ b/content/common/BUILD.gn
@@ -238,6 +238,13 @@ source_set("common") {
libs += [ "android" ]
}
+ if (is_debug && !is_component_build) {
+ # Content depends on the PPAPI message logging stuff; if this isn't here,
+ # some unit test binaries won't compile. This only worked in release mode
+ # because logging is disabled there.
+ deps += [ "//ppapi/proxy:ipc_sources" ]
+ }
+
if (is_ios) {
sources -= [ "user_agent.cc" ]
assert(false, "Need to add lots of conditions here")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698