Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1088013002: gn: Fix gn build so cloud_print_unittests doesn't fail. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Fix gn build so cloud_print_unittests doesn't fail in debug static builds. BUG=none Committed: https://crrev.com/85ac931d6d6d8bb53a0e5e02a48be6de6256853b Cr-Commit-Position: refs/heads/master@{#325478}

Patch Set 1 #

Patch Set 2 : Do jam@'s suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/common/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Elliot Glaysher
5 years, 8 months ago (2015-04-14 23:27:47 UTC) #2
jam
ok i looked into this a bit more since it seemed confusing that this file ...
5 years, 8 months ago (2015-04-15 17:12:16 UTC) #3
Elliot Glaysher
Did what you sent me in im. ptal.
5 years, 8 months ago (2015-04-15 20:28:16 UTC) #4
jam
lgtm
5 years, 8 months ago (2015-04-16 03:54:35 UTC) #5
jam
On 2015/04/16 03:54:35, jam wrote: > lgtm (I updated the description to make it clear ...
5 years, 8 months ago (2015-04-16 03:55:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088013002/20001
5 years, 8 months ago (2015-04-16 18:06:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 18:21:04 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:21:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85ac931d6d6d8bb53a0e5e02a48be6de6256853b
Cr-Commit-Position: refs/heads/master@{#325478}

Powered by Google App Engine
This is Rietveld 408576698