Add an initial implementation of net-internals inspector in javascript....

Add an initial implementation of net-internals inspector in javascript.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42357

[Mike Belshe, 2010-03-22 20:34:07]

a couple minor nits.... 

I need to do one more pass through this.

http://codereview.chromium.org/1088007/diff/7002/8006
File chrome/browser/resources/net_internals/loggrouper.js (right):

http://codereview.chromium.org/1088007/diff/7002/8006#newcode17
chrome/browser/resources/net_internals/loggrouper.js:17: function
LogGroupEntry(origEntry, i) {
nit: I guess 'i' is 'index'?

http://codereview.chromium.org/1088007/diff/7002/8011
File chrome/browser/resources/net_internals/logviewpainter.js (right):

http://codereview.chromium.org/1088007/diff/7002/8011#newcode38
chrome/browser/resources/net_internals/logviewpainter.js:38:
makeLoadLogTable_(div, groupedEntries);
nit: so each time we add an entry the entire table gets reconstructed?  that
might not scale too well? If so, maybe a TODO() is in order here.

http://codereview.chromium.org/1088007/diff/7002/8017
File chrome/common/chrome_paths.h (right):

http://codereview.chromium.org/1088007/diff/7002/8017#newcode27
chrome/common/chrome_paths.h:27: DIR_NET_INTERNALS,            // Directory
where net inspector is located.
nit: "net inspector" -> "net internals"?

[eroman, 2010-03-22 21:36:26]

Thanks for the initial review!

http://codereview.chromium.org/1088007/diff/7002/8006
File chrome/browser/resources/net_internals/loggrouper.js (right):

http://codereview.chromium.org/1088007/diff/7002/8006#newcode17
chrome/browser/resources/net_internals/loggrouper.js:17: function
LogGroupEntry(origEntry, i) {
On 2010/03/22 20:34:07, Mike Belshe wrote:
> nit: I guess 'i' is 'index'?

Renamed it to |index|.

http://codereview.chromium.org/1088007/diff/7002/8011
File chrome/browser/resources/net_internals/logviewpainter.js (right):

http://codereview.chromium.org/1088007/diff/7002/8011#newcode38
chrome/browser/resources/net_internals/logviewpainter.js:38:
makeLoadLogTable_(div, groupedEntries);
On 2010/03/22 20:34:07, Mike Belshe wrote:
> nit: so each time we add an entry the entire table gets reconstructed?  that
> might not scale too well? If so, maybe a TODO() is in order here.

Correct -- each time one of the selected sources is updated, the details view is
redrawn on a 50ms timer.

I found the performance in the common case to be ok, since requests don't
generally have that many entries added to them, and generally by the time you
click on them they have already completed.

That said, I have a TODO at the top of the file about doing something better for
the details view (I am not very happy with the LoadLog style hiearchicial
display), and the updating could be optimized at that point.

http://codereview.chromium.org/1088007/diff/7002/8017
File chrome/common/chrome_paths.h (right):

http://codereview.chromium.org/1088007/diff/7002/8017#newcode27
chrome/common/chrome_paths.h:27: DIR_NET_INTERNALS,            // Directory
where net inspector is located.
On 2010/03/22 20:34:07, Mike Belshe wrote:
> nit: "net inspector" -> "net internals"?

Done.

[eroman, 2010-03-22 22:52:38]

Note I added the .gyp changes now.

[Mike Belshe, 2010-03-23 16:15:34]

lgtm! this is a lot of work!  Thanks, eric!