Chromium Code Reviews
Help | Chromium Project | Sign in
(682)

Issue 1088007: Add an initial implementation of net-internals inspector in javascript.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add an initial implementation of net-internals inspector in javascript.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42357

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : update an error message to show file path #

Patch Set 4 : address mbelshe's comments #

Patch Set 5 : add the build file #

Patch Set 6 : more build file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1413 lines, -81 lines) Lint Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M chrome/browser/dom_ui/net_internals_ui.cc View 1 2 10 chunks +171 lines, -52 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/detailsview.js View 1 chunk +93 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/index.html View 1 2 1 chunk +60 lines, -27 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/layoutmanager.js View 1 chunk +151 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/loggrouper.js View 1 2 3 1 chunk +95 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/logviewpainter.js View 1 2 3 1 chunk +117 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/main.css View 1 chunk +134 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/main.js View 1 chunk +90 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/requestsview.js View 1 chunk +165 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/sourceentry.js View 1 chunk +182 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/timelineviewpainter.js View 1 chunk +20 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/util.js View 1 chunk +88 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 2 chunks +26 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_paths.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_paths.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
M net/base/net_log.h View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M net/base/net_log.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments 1 errors Download
M net/socket/client_socket_pool_base.cc View 1 2 1 chunk +2 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 5
eroman
4 years, 1 month ago #1
Mike Belshe
a couple minor nits.... I need to do one more pass through this. http://codereview.chromium.org/1088007/diff/7002/8006 File ...
4 years, 1 month ago #2
eroman
Thanks for the initial review! http://codereview.chromium.org/1088007/diff/7002/8006 File chrome/browser/resources/net_internals/loggrouper.js (right): http://codereview.chromium.org/1088007/diff/7002/8006#newcode17 chrome/browser/resources/net_internals/loggrouper.js:17: function LogGroupEntry(origEntry, i) { ...
4 years, 1 month ago #3
eroman
Note I added the .gyp changes now.
4 years, 1 month ago #4
Mike Belshe
4 years, 1 month ago #5
lgtm! this is a lot of work!  Thanks, eric!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6