chrome/browser/extensions/page_action_controller.cc - Issue 10880064: Make extension commands grant the activeTab permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/page_action_controller.cc

Issue 10880064: Make extension commands grant the activeTab permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update GTK with the TabContents changes Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/page_action_controller.cc

diff --git a/chrome/browser/extensions/page_action_controller.cc b/chrome/browser/extensions/page_action_controller.cc

index 162840f3bfea5448acfac1e3050bdff50f46236c..bcb7701dd420a8a52d92ff745ae52c5bb22335ed 100644

--- a/chrome/browser/extensions/page_action_controller.cc

+++ b/chrome/browser/extensions/page_action_controller.cc

@@ -54,7 +54,7 @@ LocationBarController::Action PageActionController::OnClicked(

int tab_id = ExtensionTabUtil::GetTabId(web_contents());

extensions::TabHelper::FromWebContents(web_contents())->

- active_tab_permission_manager()->GrantIfRequested(extension);

+ active_tab_permission_granter()->GrantIfRequested(extension);

switch (mouse_button) {

case 1: // left