Make extension commands grant the activeTab permission.

chrome/browser/ui/extensions/shell_window.cc

Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index 5ba6c0a9b32a78d50caf95340f1e68b603ffe0b0..97bc05d6bfd885520bf98b2003937acf2b5c1686 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -9,6 +9,7 @@
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/shell_window_geometry_cache.h"
 #include "chrome/browser/extensions/shell_window_registry.h"
+#include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/file_select_helper.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
 #include "chrome/browser/intents/web_intents_util.h"
@@ -430,6 +431,12 @@ ShellWindow::GetExtensionWindowController() const {
   return NULL;
 }
 
+extensions::ActiveTabPermissionGranter*
+    ShellWindow::GetActiveTabPermissionGranter() {
+  return extensions::TabHelper::FromWebContents(web_contents_)->

[Aaron Boodman, 2012/09/21 01:54:43]

I don't expect to see any platform app changes in this CL. This class is the
frame for platform apps. What does wiring this here enable?

[not at google - send to devlin, 2012/09/21 01:59:10]

Compilation?

[not at google - send to devlin, 2012/09/21 02:03:26]

Another way to make it compile would be for every shell window implementation to
implement the delegate interface itself, but this was easier.

Yet another would be to let ExtensionKeybindingRegistry either:
1. accept a NULL delegate (but then if we need to add anything to it in the
future then that'd need to change)
2. allow GetActiveTabPermissionGranter to return NULL (seems ok but if we're
implementing the Delegate interface then might as well do it, maybe, maybe not).

[Aaron Boodman, 2012/09/21 02:45:40]

Does TabHelper::FromWebContents() return non-NULL for shell windows? I wouldn't
have thought shell windows have a tab helper (they don't have any tabs).

In any case, I think that this class should return NULL.

+      active_tab_permission_granter();
+}
+
 void ShellWindow::OnRequest(const ExtensionHostMsg_Request_Params& params) {
   extension_function_dispatcher_.Dispatch(params,
                                           web_contents_->GetRenderViewHost());