Make extension commands grant the activeTab permission.

chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h"
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/api/commands/command_service_factory.h"
 #include "chrome/browser/extensions/browser_event_router.h"

[Finnur, 2012/09/21 10:07:00]

Can this be removed now?

[not at google - send to devlin, 2012/09/23 23:53:18]

Done.

 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
 
 namespace values = extension_manifest_values;
 
 // static
 void extensions::ExtensionKeybindingRegistry::SetShortcutHandlingSuspended(
     bool suspended) {
   ExtensionKeybindingRegistryCocoa::set_shortcut_handling_suspended(suspended);
 }
 
 bool ExtensionKeybindingRegistryCocoa::shortcut_handling_suspended_ = false;
 
 ExtensionKeybindingRegistryCocoa::ExtensionKeybindingRegistryCocoa(
     Profile* profile,
     gfx::NativeWindow window,
-    ExtensionFilter extension_filter)
-    : ExtensionKeybindingRegistry(profile, extension_filter),
+    ExtensionFilter extension_filter,
+    Delegate* delegate)
+    : ExtensionKeybindingRegistry(profile, extension_filter, delegate),
       profile_(profile),
       window_(window) {
   Init();
 }
 
 ExtensionKeybindingRegistryCocoa::~ExtensionKeybindingRegistryCocoa() {
 }
 
 bool ExtensionKeybindingRegistryCocoa::ProcessKeyEvent(
     const content::NativeWebKeyboardEvent& event) {
@@ skipping 12 matching lines @@
   int type = 0;
   if (command_name == values::kPageActionCommandEvent) {
     type = chrome::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC;
   } else if (command_name == values::kBrowserActionCommandEvent) {
     type = chrome::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC;
   } else if (command_name == values::kScriptBadgeCommandEvent) {
     type = chrome::NOTIFICATION_EXTENSION_COMMAND_SCRIPT_BADGE_MAC;
   } else {
     // Not handled by using notifications. Route it through the Browser Event
     // Router.
-    ExtensionService* service = profile_->GetExtensionService();
-    service->browser_event_router()->CommandExecuted(
-        profile_, extension_id, command_name);
+    CommandExecuted(extension_id, command_name);
     return true;
   }
 
   std::pair<const std::string, gfx::NativeWindow> details =
       std::make_pair(extension_id, window_);
   content::NotificationService::current()->Notify(
       type,
       content::Source<Profile>(profile_),
       content::Details<
           std::pair<const std::string, gfx::NativeWindow> >(&details));
@@ skipping 64 matching lines @@
     const extensions::Extension* extension,
     const std::string& command_name) {
   EventTargets::iterator iter = event_targets_.begin();
   while (iter != event_targets_.end()) {
     EventTargets::iterator old = iter++;
     if (old->second.first == extension->id() &&
         (command_name.empty() || (old->second.second == command_name)))
       event_targets_.erase(old);
   }
 }