Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1087983003: Revert of Remove swap ack throttling to regain performance regression on freon (Closed)

Created:
5 years, 8 months ago by brianderson
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove swap ack throttling to regain performance regression on freon (patchset #4 id:80001 of https://codereview.chromium.org/1053153003/) Reason for revert: Despite throughput wins, this increased hang rates, broke pdfs, and regressed latency. Original issue's description: > Remove swap ack throttling to regain performance regression on freon. > > In the past eglSwapBuffers used to return early, before the swap actually happened and descheduling in the driver. This resulted in the scheduler beginning the next frame early and hitting the page flip deadline in time more often. > > Freon returns swap ack when page flip actually happened, but with the side effect of scheduling shifted forward, resulting in more missed vblanks and reduced performance. > > This change restores original performance on freon. > > BUG=465599 > > Committed: https://crrev.com/faa924ff38e80006a27ac85fcc95f3dcbe441d55 > Cr-Commit-Position: refs/heads/master@{#324465} TBR=danakj@chromium.org,skyostil@chromium.org,alexst@chromium.org BUG=465599, 311213, 477082 Committed: https://crrev.com/ce413fbbfc4eb065a7591972d4f886099631880a Cr-Commit-Position: refs/heads/master@{#325158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 4 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brianderson
Created Revert of Remove swap ack throttling to regain performance regression on freon
5 years, 8 months ago (2015-04-14 22:39:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087983003/1
5 years, 8 months ago (2015-04-14 22:40:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087983003/1
5 years, 8 months ago (2015-04-14 22:43:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 00:39:49 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 00:40:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce413fbbfc4eb065a7591972d4f886099631880a
Cr-Commit-Position: refs/heads/master@{#325158}

Powered by Google App Engine
This is Rietveld 408576698