Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1087983002: Use IsOriginSecure when checking Web MIDI SYSEX capability. (Closed)

Created:
5 years, 8 months ago by palmer
Modified:
5 years, 8 months ago
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@origin-is-secure-gurl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IsOriginSecure when checking Web MIDI SYSEX capability. Rather than the previous ad hoc check. IsOriginSecure is the standard way. BUG=362214, 470170 Committed: https://crrev.com/298d7eb01ab6f9c1f8781a31c2fddc13f9e4e4e2 Cr-Commit-Position: refs/heads/master@{#325717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/content_settings/permission_context_base.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
palmer
This CL depends on https://codereview.chromium.org/1049533002/ (Add IsOriginSecure and GURL::SchemeUsesTLS.) so cannot land before that one ...
5 years, 8 months ago (2015-04-14 22:36:59 UTC) #2
Takashi Toyoshima
I may replace this check code to somewhere to be consistent with Permissions API (see ...
5 years, 8 months ago (2015-04-15 04:47:47 UTC) #3
markusheintz_
LGTM. Thanks a lot for this change!
5 years, 8 months ago (2015-04-15 09:53:31 UTC) #4
Takashi Toyoshima
Markus, by the way, do you have any thoughts on https://code.google.com/p/chromium/issues/detail?id=474545 ?
5 years, 8 months ago (2015-04-15 09:57:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087983002/1
5 years, 8 months ago (2015-04-17 17:59:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 21:09:32 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 21:10:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298d7eb01ab6f9c1f8781a31c2fddc13f9e4e4e2
Cr-Commit-Position: refs/heads/master@{#325717}

Powered by Google App Engine
This is Rietveld 408576698