Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 108793005: Add base:: to string16s in ipc/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ipc/ipc_channel_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dan Beam
7 years ago (2013-12-19 05:09:06 UTC) #1
Tom Sepez
lgtm
7 years ago (2013-12-19 19:30:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/108793005/1
7 years ago (2013-12-19 19:38:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=238565
7 years ago (2013-12-19 21:08:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/108793005/1
7 years ago (2013-12-19 21:20:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108282
7 years ago (2013-12-20 02:43:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/108793005/1
7 years ago (2013-12-20 02:58:49 UTC) #7
Dan Beam
7 years ago (2013-12-20 09:05:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 manually as r242050 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698