Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/renderer/frame_sniffer.h

Issue 10879105: Moving Chrome code from using WebFrame::name to WebFrame::uniqueName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing member name. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/renderer/frame_sniffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_FRAME_SNIFFER_H_ 5 #ifndef CHROME_RENDERER_FRAME_SNIFFER_H_
6 #define CHROME_RENDERER_FRAME_SNIFFER_H_ 6 #define CHROME_RENDERER_FRAME_SNIFFER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "content/public/renderer/render_view_observer.h" 10 #include "content/public/renderer/render_view_observer.h"
11 11
12 // Class which observes events from the frame with specific name and sends IPC 12 // Class which observes events from the frame with specific name and sends IPC
13 // messages to be handled by RenderViewHostObserver. 13 // messages to be handled by RenderViewHostObserver.
14 class FrameSniffer : public content::RenderViewObserver { 14 class FrameSniffer : public content::RenderViewObserver {
15 public: 15 public:
16 FrameSniffer(content::RenderView* render_view, const string16 &frame_name); 16 FrameSniffer(content::RenderView* render_view, const string16 &frame_name);
jam 2012/08/29 15:11:26 nit: maybe change this as well to make it clear wh
nasko 2012/08/29 15:38:59 Done.
17 virtual ~FrameSniffer(); 17 virtual ~FrameSniffer();
18 18
19 // Implements RenderViewObserver. 19 // Implements RenderViewObserver.
20 virtual void DidFailProvisionalLoad( 20 virtual void DidFailProvisionalLoad(
21 WebKit::WebFrame* frame, const WebKit::WebURLError& error) OVERRIDE; 21 WebKit::WebFrame* frame, const WebKit::WebURLError& error) OVERRIDE;
22 virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame, 22 virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame,
23 bool is_new_navigation) OVERRIDE; 23 bool is_new_navigation) OVERRIDE;
24 24
25 private: 25 private:
26 bool ShouldSniffFrame(WebKit::WebFrame* frame); 26 bool ShouldSniffFrame(WebKit::WebFrame* frame);
27 27
28 // Name of the frame to be monitored. 28 // Name of the frame to be monitored.
29 string16 frame_name_; 29 string16 unique_frame_name_;
30 30
31 DISALLOW_COPY_AND_ASSIGN(FrameSniffer); 31 DISALLOW_COPY_AND_ASSIGN(FrameSniffer);
32 }; 32 };
33 33
34 #endif // CHROME_RENDERER_FRAME_SNIFFER_H_ 34 #endif // CHROME_RENDERER_FRAME_SNIFFER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/frame_sniffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698